Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

On 6 October 2016 at 16:42, Zachary Turner wrote: > I'm not sure actually. I only noticed this because I was in IRC and I saw > the message go by about the failure. > > Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer > for you. I'm not sure why

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

I'm not sure actually. I only noticed this because I was in IRC and I saw the message go by about the failure. Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer for you. On Thu, Oct 6, 2016 at 12:02 PM Giusti, Valentina < valentina.giu...@intel.com> wrote: > Ok, I

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

Seems like this has caused this buildbot failure: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/12936/steps/ninja%20build%20local/logs/stdio On Thu, Oct 6, 2016 at 11:14 AM Valentina Giusti wrote: > This revision was automatically updated to

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

This revision was automatically updated to reflect the committed changes. Closed by commit rL283474: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel… (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D25329?vs=73823=73826#toc

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

valentinagiusti updated this revision to Diff 73823. valentinagiusti added a comment. fixed usage of llvm:raw_string_ostream https://reviews.llvm.org/D25329 Files: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

zturner added inline comments. > CrashReason.cpp:38 > + stream << ")"; > + str += stream.str(); > +} Actually I'm not sure this is correct. Since you initialize the stream with `str`, as soon as you call `stream.str()` it will flush everything to the underlying string. Now `str` will

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

valentinagiusti updated this revision to Diff 73811. valentinagiusti added a comment. used llvm:raw_string_ostream instead of std::stringstream https://reviews.llvm.org/D25329 Files: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

Can you use llvm:raw_string_ostream instead of std::stringstream? After that this looks fine On Thu, Oct 6, 2016 at 8:51 AM Pavel Labath wrote: > labath accepted this revision. > labath added a comment. > This revision is now accepted and ready to land. > > lgtm. > > At one

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. At one point I'd like to change this code to not transfer the "crash reason" as string, but in a more structured way (i.e., `qXfer:siginfo:read` packet), but that is certainly out of

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

valentinagiusti created this revision. valentinagiusti added reviewers: zturner, labath. valentinagiusti added subscribers: emaste, lldb-commits. This patch adds support for handling the SIGSEGV signal with 'si_code == SEGV_BNDERR', which is thrown when a bound violation is caught by the Intel(R)