beanz added inline comments.
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:1418
"include")),
-'LD_EXTRAS': "-L%s -llldb" % lib_dir}
+'LD_EXTRAS': "-L%s/../lib -llldb
fjricci added inline comments.
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:1418
"include")),
-'LD_EXTRAS': "-L%s -llldb" % lib_dir}
+'LD_EXTRAS': "-L%s/../lib -llldb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285541: [Test Suite] Properly respect --framework option
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D25886?vs=75505=76351#toc
Repository:
rL LLVM
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
I do wonder if we should have a general helper for lines like this:
sys.platform.rstrip('0123456789') in ('freebsd', 'linux', 'netbsd', 'darwin')
but that doesn't have to be
zturner added a comment.
Maybe put that function `lldbplatformutil`?
https://reviews.llvm.org/D25886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
beanz created this revision.
beanz added a reviewer: tfiala.
beanz added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
dotest.py has a framework option that is not respected. This patch makes the
framework path properly configurable via the --framework option.
This patch also
