[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath abandoned this revision. labath marked 2 inline comments as done. labath added a comment. The new version of this patch is in https://reviews.llvm.org/D28880. https://reviews.llvm.org/D27289 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

jasonmolenda added a comment. @labath intersting idea, sending a blob of stack memory above the current stack pointer reg value to accelerate an unwind. If you have a lot of small stack frames, it could be a performance benefit. Common/simple methods do their work in 32-64 bytes of stack

Re: [Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

> On Dec 2, 2016, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > >> @labath ah I see I hadn't looked at the lldb-server packets so I didn't know

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath added a comment. In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > @labath ah I see I hadn't looked at the lldb-server packets so I didn't know > you had jThreadsInfo, good to hear. Yes, if your target is built mostly > -fomit-frame-pointer, lldb-server won't be able to

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

jasonmolenda added a comment. @labath ah I see I hadn't looked at the lldb-server packets so I didn't know you had jThreadsInfo, good to hear. Yes, if your target is built mostly -fomit-frame-pointer, lldb-server won't be able to do a stack walk without reading eh_frame or the arm unwind info

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath added a comment. Looks like a good starting point. Apart from some style nits, I'd like us to remove sending of the `registers` field in the `jstopinfo`, as it is not necessary anymore. Also, we should add an lldb-server style test for this. @jasonmolenda, we already have jThreadsInfo

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

jasonmolenda added a comment. For what it's worth, this change was part of the changes we made to reduce packet traffic for "private stops". When a high-level "step" or "next" command is done, we instruction step (or fast-step with Jim's fast-step code when it sees a sequence of instructions

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

jmajors created this revision. jmajors added a reviewer: labath. jmajors added a subscriber: lldb-commits. Herald added a subscriber: danalbert. To prevent costly calls to the server to get the PC for every thread, add all the thread's PCs to the jstopinfo message. This also makes the