valentinagiusti added a comment.
I am not sure what you mean, this is a pluggable command and as such it has to
be a dynamic loadable lib.
As for the wrong install name of the binary, I don't think I can fix it from
here, the SOVERSION is set by AddLLVM.cmake.
On which platform did you get this
sylvestre.ledru added a comment.
Like llvm or lldb in general, just integrate it into liblldb?
By the way, liblldb-intel-mpxtable.so-5.0 is incorrect should be
liblldb-intel-mpxtable.so.5.0
Repository:
rL LLVM
https://reviews.llvm.org/D29078
valentinagiusti added a comment.
Do you have a better proposal?
Repository:
rL LLVM
https://reviews.llvm.org/D29078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sylvestre.ledru added a comment.
This change is creating a new library
usr/lib/llvm-5.0/bin/liblldb-intel-mpxtable.so on GNU/Linux 64b
That sounds pretty specific, is that really something that we want to do?
Repository:
rL LLVM
https://reviews.llvm.org/D29078
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293660: Add a command to access and manipulate the Intel(R)
MPX Boundary Tables. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D29078?vs=85906=86453#toc
Repository:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
If we can add a comment around "bndcfgu" where we use an SBData since it is a
vector register and SBValue::GetValueAsUnsigned(...) won't work because it is a
vector that would be nice for
valentinagiusti updated this revision to Diff 85906.
valentinagiusti marked an inline comment as done.
valentinagiusti added a comment.
used GetAddress() instead of GetUnsignedIntXX()
https://reviews.llvm.org/D29078
Files:
tools/CMakeLists.txt
tools/intel-mpx/CMakeLists.txt
valentinagiusti marked 2 inline comments as done.
valentinagiusti added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:219
+}
+
+static std::vector uIntToU8(uint64_t input, size_t size) {
clayborg wrote:
> I'll fix SBData and this should
clayborg added a comment.
Let me know why your GetValueAsUnsigned isn't working on your register by
stepping through it.
https://reviews.llvm.org/D29078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg added a comment.
I fixed SBData with:
Sendingpackages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py
Sendingsource/API/SBData.cpp
Transmitting file data ..done
Committing transaction...
Committed revision 293102.
https://reviews.llvm.org/D29078
clayborg added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:151
+ //
+ bd_entry--;
+
clayborg wrote:
> There is indeed a bug in SBData::SetData():
>
> ```
> void SBData::SetData(lldb::SBError , const void *buf, size_t size,
>
clayborg added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:151
+ //
+ bd_entry--;
+
There is indeed a bug in SBData::SetData():
```
void SBData::SetData(lldb::SBError , const void *buf, size_t size,
valentinagiusti updated this revision to Diff 85733.
valentinagiusti added a comment.
Applied some of the proposed changes.
https://reviews.llvm.org/D29078
Files:
tools/CMakeLists.txt
tools/intel-mpx/CMakeLists.txt
tools/intel-mpx/IntelMPXTablePlugin.cpp
tools/intel-mpx/test/Makefile
valentinagiusti marked 3 inline comments as done.
valentinagiusti added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:199-218
+ if (arch == llvm::Triple::ArchType::x86_64) {
+lbound = toU64(bt_entry_v[7], bt_entry_v[6], bt_entry_v[5], bt_entry_v[4],
+
valentinagiusti marked 2 inline comments as done.
valentinagiusti added a comment.
Hi Greg, thanks a lot for your review. I have a question about the API that you
proposed, please have a look at the inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:143-150
granata.enrico resigned from this revision.
granata.enrico added a comment.
I don't work on LLDB anymore. Resigning as reviewer. Best of luck with your
patch :-)
https://reviews.llvm.org/D29078
___
lldb-commits mailing list
clayborg added a comment.
Noticed another efficiency thing, see inlined comment.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:37
+ ptr_str.insert(0, "&");
+ lldb::SBValue ptr_addr = frame.GetValueForVariablePath(ptr_str.c_str());
+ if (!ptr_addr.IsValid()) {
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
There are a few places where you are reading memory and then wanting to decode
data from it. Right now, you first read memory into a local buffer and then we
create an SBData
valentinagiusti created this revision.
Herald added a subscriber: mgorny.
The Boundary Table Entries are stored in the application memory and allow
to store boundary info for all the pointers of the program, also those that
otherwise wouldn't fit in the 4 bound registers provided by the HW.
Here
19 matches
Mail list logo
