emaste added a comment.
In https://reviews.llvm.org/D29347#662503, @labath wrote:
> @emaste: I'd suggest switching freebsd over to this process launcher as well.
> I think it's the last user of the ProcessLauncherPosix, and it would enable
> us to get rid of it.
Indeed. I won't be able to loo
krytarowski updated this revision to Diff 86546.
krytarowski added a comment.
virtual -> override
Repository:
rL LLVM
https://reviews.llvm.org/D29347
Files:
include/lldb/Host/linux/ProcessLauncherLinux.h
include/lldb/Host/posix/ProcessLauncherPosixFork.h
source/Host/CMakeLists.txt
so
labath added a comment.
@emaste: I'd suggest switching freebsd over to this process launcher as well. I
think it's the last user of the ProcessLauncherPosix, and it would enable us to
get rid of it.
Repository:
rL LLVM
https://reviews.llvm.org/D29347
_
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Perfect. Thank you.
Comment at: include/lldb/Host/posix/ProcessLauncherPosixFork.h:19
+public:
+ virtual HostProcess LaunchProcess(const ProcessLaunchInfo &launch_info,
+
krytarowski updated this revision to Diff 86536.
krytarowski added a comment.
Fix typo.
Repository:
rL LLVM
https://reviews.llvm.org/D29347
Files:
include/lldb/Host/linux/ProcessLauncherLinux.h
include/lldb/Host/posix/ProcessLauncherPosixFork.h
source/Host/CMakeLists.txt
source/Host/
