This revision was automatically updated to reflect the committed changes.
Closed by commit rL294515: [CMake] Final dependency cleanup patch! (authored by
cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D29352?vs=87265&id=87701#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
beanz added a comment.
Ok. I think this patch is fully ready to go now. I added the missing
dependencies in the ObjectFileELF tests in https://reviews.llvm.org/rL294372.
Thank you @labath for all your patience and help testing this patch. I've
tested it on Darwin and FreeBSD in the current inca
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great.
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
beanz updated this revision to Diff 87265.
beanz added a comment.
Rebasing patch
https://reviews.llvm.org/D29352
Files:
cmake/LLDBDependencies.cmake
cmake/modules/AddLLDB.cmake
source/API/CMakeLists.txt
source/Initialization/CMakeLists.txt
source/Plugins/Process/CMakeLists.txt
sourc
labath added a comment.
the newlines were a red herring. I think the problem is that you forgot to use
the LINK_LIBS argument (see comment).
This works on linux after applying this change (and fixing ObjectFileELF test
dependencies, which you missed because they were added yesterday).
==
labath added a comment.
BTW, I just noticed that the Breakpoint change has dos line breaks for some
reason. Maybe that could be the cause. I'll try it out tomorrow.
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.ll
labath added a comment.
Unfortunately, I am still getting undefined symbols when building some of the
unittest binaries:
FAILED: : && /usr/bin/clang++-3.6 -fPIC -fvisibility-inlines-hidden -Wall
-W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wn
beanz updated this revision to Diff 86721.
beanz added a comment.
Unit tests are updated in https://reviews.llvm.org/rL293821. This update makes
one last change to the unit tests to build with the explicit dependencies.
https://reviews.llvm.org/D29352
Files:
cmake/LLDBDependencies.cmake
cm
beanz added a comment.
Ah! I forgot to update the unittest directory. I'll get a patch in today that
updates the unittests following the pattern from the libraries.
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.ll
labath added a comment.
The main code seems to be fine now, but linking of unit tests (check-lldb-unit
target) fails now. You'll probably need to explicitly set their dependencies as
well before this can be removed.
https://reviews.llvm.org/D29352
___
beanz updated this revision to Diff 86509.
beanz added a comment.
Fixing the issue labath reported in the review. Generally speaking we shouldn't
be configuring or compiling plugins that can't be used.
https://reviews.llvm.org/D29352
Files:
cmake/LLDBDependencies.cmake
cmake/modules/AddLLD
labath added a comment.
When linking liblldb.so:
/usr/bin/ld.gold: error: cannot find -llldbPluginDynamicLoaderDarwinKernel
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
labath added a comment.
I'll give this a spin on linux now.
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
beanz created this revision.
Herald added subscribers: jgosnell, mgorny, srhines, danalbert.
This patch removes the over-specified dependencies from LLDBDependencies and
instead relies on the dependencies as expressed in each library and tool.
This also removes the library looping in favor of al
14 matches
Mail list logo
