Re: [Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

Not to be snarky, but that's why we put comments in headers... Jim > On Feb 3, 2017, at 4:47 PM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > I guess the same way you would know how to use any part of a library or API. > The first time

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

jingham added a comment. That's kind of a Meno response... How would I know to look for them if I don't know they are there. These format strings are only used in a couple of places. Those calls should tell me that I CAN use these format strings and where/how to find them.

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

labath updated this revision to Diff 87046. labath added a comment. Herald added a subscriber: mgorny. Add ConstString formatter and use it. https://reviews.llvm.org/D29510 Files: include/lldb/Core/Log.h include/lldb/Core/Logging.h include/lldb/Utility/ConstString.h

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

zturner added a comment. In https://reviews.llvm.org/D29510#666443, @jingham wrote: > This is sort of a side question, but Pavel's comment brought it up. If I > were new to this stuff, and wanted to know which entities had formatters and > which didn't, how would I find that out easily?

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

jingham accepted this revision. jingham added a comment. Oh, yeah, and I should remember to check okay... https://reviews.llvm.org/D29510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

jingham added a comment. This is sort of a side question, but Pavel's comment brought it up. If I were new to this stuff, and wanted to know which entities had formatters and which didn't, how would I find that out easily? There are a couple of Format calls that use it, maybe they should

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

clayborg added inline comments. Comment at: source/Target/SectionLoadList.cpp:70 bool warn_multiple) { - Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER | -

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

labath added a comment. Comment at: source/Target/SectionLoadList.cpp:70 bool warn_multiple) { - Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER | -

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

jingham added a comment. Thanks for taking the trouble to clean that up, that's lovely! https://reviews.llvm.org/D29510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D29510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

labath added a reviewer: clayborg. labath added a comment. Adding greg in case he has some thoughts on this as well. https://reviews.llvm.org/D29510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

labath created this revision. Per discussion in https://reviews.llvm.org/D28616, having two ways two request logging (log enable lldb XXX verbose && log enable -v lldb XXX) is confusing. This removes the first option and standardizes all code to use the second one. I've added a LLDB_LOGV macro