[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-31 Thread Tamas Berghammer via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299249: Do not dereference std::unique_ptr by default (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D31366?vs=93039=93699#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-30 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. MacOS hasn't shipped with gcc for a while now. If you were serious about using gcc & its STL implementation you would install your own copies of the tools & libraries. So what's on the

[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-30 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added a comment. I tried it out on OSX and the problem is that version of libstdc++ shipping with every recent OSX version (don't know about old ones) is 4.2.1 (last version with GPL v2) what doesn't support std::unique_ptr (supported since 4.3). Because of this I think the correct

[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-28 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added a comment. My understanding (don't have an OSX machine at hand right now to try out) is that OSX ships with the libstdc++ belonging to gcc-4.2.1 and that version of libstdc++ is too old to support c++11 features such as std::unique_ptr. Regarding skipping tests I am not aware

[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. There's no reason you couldn't build the gnu libstdc++ on Darwin. Anyway, if that's the problem, I'm pretty sure the testsuite has a way to conditionalize on which stdlib(s) are available. That would be clearer than conditionalizing on platform.

[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-27 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer requested review of this revision. tberghammer added a comment. I am trying to compile it with the following command on OSX but I wasn't able to get it working: clang -std=c++11 -g -O0 -fno-builtin -arch x86_64 -fno-limit-debug-info

[Lldb-commits] [PATCH] D31366: Do not dereference std::unique_ptr by default

2017-03-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This test compiles correctly on Darwin if you pass the --std=c++11 flag. lldbtest has a getstdFlag that returns the correct std value in this case. Can you get the test running