This revision was automatically updated to reflect the committed changes.
Closed by commit rL299251: Add support for sythetic operator dereference
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D31368?vs=93529=93701#toc
Repository:
rL LLVM
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Excellent!
https://reviews.llvm.org/D31368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer updated this revision to Diff 93529.
tberghammer added a comment.
Fix grammer for the html documentation.
https://reviews.llvm.org/D31368
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/TestDataFormatterStdUniquePtr.py
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
One grammar comment in the docs, and then this is good.
Comment at: www/varformats.html:1071
[3] This method is optional (starting with SVN revision 219330).
tberghammer updated this revision to Diff 93525.
tberghammer added a comment.
Add documentation to the website
https://reviews.llvm.org/D31368
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/TestDataFormatterStdUniquePtr.py
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This seems great. The only remaining thing is to document this in the
Synthetic Children section of the Variable Formatting page
(www/varformats.html).
tberghammer updated this revision to Diff 93241.
tberghammer added a comment.
Changed StackFrame to use Dereference instead of accessing the $$dereference$$
magic field.
https://reviews.llvm.org/D31368
Files:
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The idea here seems fine, but why does StackFrame have to know the magic
$$dereference$$? Why can't it call the Dereference on the synthetic value?
tberghammer created this revision.
After this change a sythetic child provider can generate a special child
named "$$dereference$$" what if present is used when "operator*" or
"operator->" used on a ValueObject. The goal of the change is to make
expressions like "up->foo" work inside the "frame
