This revision was automatically updated to reflect the committed changes.
Closed by commit rL298953: Add support for tracing hello-world application on
NetBSD (authored by kamil).
Changed prior to commit:
https://reviews.llvm.org/D31374?vs=93312=93315#toc
Repository:
rL LLVM
krytarowski updated this revision to Diff 93312.
krytarowski added a comment.
Apply changes from review.
Repository:
rL LLVM
https://reviews.llvm.org/D31374
Files:
source/Plugins/Process/NetBSD/CMakeLists.txt
source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
krytarowski added a comment.
This code is used as a base for further improvements, I'm going to commit it...
debugging hello world still works.
$ lldb ./hello
krytarowski added a comment.
In https://reviews.llvm.org/D31374#712221, @labath wrote:
> I wasn't able to go into this too deeply, but here is what I have after a
> quick pass. I won't be able to review this thoroughly that soon, but I think
> it can go in after you take my comments into
labath added a comment.
I wasn't able to go into this too deeply, but here is what I have after a quick
pass. I won't be able to review this thoroughly that soon, but I think it can
go in after you take my comments into consideration.
Comment at:
krytarowski added a comment.
Right now I'm not sure how to optimize reading GPR. If possible I would
reschedule it for later.
Repository:
rL LLVM
https://reviews.llvm.org/D31374
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
krytarowski added a comment.
In https://reviews.llvm.org/D31374#710864, @kettenis wrote:
> On OpenBSD the register context used in core dumps uses the same layout as
> ptrace(2). That's not the case on all OSes, but I believe that is the case
> for NetBSD as well. Would it be possible to
kettenis added a comment.
On OpenBSD the register context used in core dumps uses the same layout as
ptrace(2). That's not the case on all OSes, but I believe that is the case for
NetBSD as well. Would it be possible to re-use the register context data
structures defined in the
krytarowski created this revision.
krytarowski added a project: LLDB.
Herald added a subscriber: mgorny.
This patch is a stripped down from features a NetBSD process
code (patch is kept under 2k LOC). This code has assumption that
there is only one thread within a debugged process. The only
