[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL300372: [CMake] Support generating Config.h (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D31969?vs=95024=95354#toc Repository: rL LLVM https://reviews.llvm.org/D31969

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

beanz updated this revision to Diff 95024. beanz added a comment. Fixing up the include guard as per feedback from zturner, and fixing up an install logic error that I spoted. https://reviews.llvm.org/D31969 Files: cmake/modules/LLDBConfig.cmake include/lldb/Host/Config.h

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

beanz added a comment. My intention in this patch is not in any way to adversely impact the Xcode project, which is the supported and documented way to build LLDB on OS X (http://lldb.llvm.org/build.html#BuildingLldbOnMacOSX). The goal of this patch is to support configuration time

Re: [Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

> On Apr 12, 2017, at 9:51 AM, Jim Ingham via lldb-commits > wrote: > >> >> On Apr 11, 2017, at 7:01 PM, Zachary Turner via Phabricator via lldb-commits >> wrote: >> >> zturner added a comment. >> >> How much would it complicate

Re: [Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

> On Apr 11, 2017, at 7:01 PM, Zachary Turner via Phabricator via lldb-commits > wrote: > > zturner added a comment. > > How much would it complicate things to move the hand maintained files out of > tree? If the Xcode build isn't really a thing we're officially

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you very much. I am soo happy that these files are going away. In https://reviews.llvm.org/D31969#724508, @zturner wrote: > How much would it complicate things to move the hand

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

zturner added a comment. How much would it complicate things to move the hand maintained files out of tree? If the Xcode build isn't really a thing we're officially supporting, perhaps we can take that aggressive approach in-tree as well? Comment at:

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

beanz updated this revision to Diff 94928. beanz added a comment. Updating the hard coded Config.h https://reviews.llvm.org/D31969 Files: cmake/modules/LLDBConfig.cmake include/lldb/Host/Config.h include/lldb/Host/Config.h.cmake include/lldb/Host/android/Config.h

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

beanz updated this revision to Diff 94925. beanz added a comment. Actually uploading the updates this time... https://reviews.llvm.org/D31969 Files: cmake/modules/LLDBConfig.cmake include/lldb/Host/Config.h include/lldb/Host/Config.h.cmake include/lldb/Host/android/Config.h

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

beanz updated this revision to Diff 94924. beanz added a comment. - Fixing installation to make sure CMake always installs the generated Config.h - Removing LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED becasue we really don't need it https://reviews.llvm.org/D31969 Files:

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

krytarowski added a comment. While there there are candidates like `pipe2`(2) in `source/Host/posix/PipePosix.cpp`. https://reviews.llvm.org/D31969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:433 +set(LLDB_CONFIG_TERMIOS_SUPPORTED ${HAVE_TERMIOS_H}) +set(LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED ${HAVE_FCNTL_H}) +if(NOT UNIX) Can we just use `#ifdef F_GETPATH` in the source code?

[Lldb-commits] [PATCH] D31969: [CMake] Support generating Config.h

beanz created this revision. Herald added subscribers: mgorny, srhines, emaste. This patch removes the hand maintained config files in favor of auto-generating the config file. We will still need to maintain the defines for the Xcode builds on Mac, but all CMake builds use the generated header