This revision was automatically updated to reflect the committed changes.
Closed by commit rL311122: [cmake] Add explicit linkage from Core to curses
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D36358?vs=109897&id=111561#toc
Repository:
rL LLVM
https://reviews.ll
mgorny added a comment.
Ping.
https://reviews.llvm.org/D36358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mgorny updated this revision to Diff 109897.
mgorny edited the summary of this revision.
mgorny added a comment.
Updated to explicitly respect LLDB_DISABLE_CURSES and the LLVM HAVE_TERMINFO
logic.
https://reviews.llvm.org/D36358
Files:
source/Core/CMakeLists.txt
Index: source/Core/CMakeLis
Dnia 5 sierpnia 2017 19:33:57 CEST, Zachary Turner
napisał(a):
>Does this evaluate to nothing if curses is not present?
I will test to confirm in a minute but it should since the find_package call
responsible for defining it is conditional to the disable var.
However, it may evaluate to a non
Does this evaluate to nothing if curses is not present?
On Sat, Aug 5, 2017 at 9:15 AM Michał Górny via Phabricator <
revi...@reviews.llvm.org> wrote:
> mgorny updated this revision to Diff 109879.
> mgorny added a comment.
>
> Forgive my poor eyesight, obviously this could go into existing LINK_L
mgorny updated this revision to Diff 109879.
mgorny added a comment.
Forgive my poor eyesight, obviously this could go into existing LINK_LIBS ;-).
https://reviews.llvm.org/D36358
Files:
source/Core/CMakeLists.txt
Index: source/Core/CMakeLists.txt
===
mgorny created this revision.
The Core library calls functions provided by the curses library. Add
an appropriate explicit LINK_LIBS to ${CURSES_LIBRARIES} to propagate
the dependency correctly within the build system.
It seems that so far the linkage was handled by some kind of implicit
magic LL
