This revision was automatically updated to reflect the committed changes.
Closed by commit rL313637: Use ThreadLauncher to launch TaskPool threads
(authored by fjricci).
Changed prior to commit:
https://reviews.llvm.org/D37930?vs=115691=115844#toc
Repository:
rL LLVM
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
I don't really have an opinion if moving TaskPool to Host is a good or bad idea
(haven't followed the recent layering efforts) but other then that looks good.
I also tested it on
fjricci updated this revision to Diff 115691.
fjricci added a comment.
Herald added subscribers: JDevlieghere, mgorny.
Move TaskPool from Utility to Host
https://reviews.llvm.org/D37930
Files:
include/lldb/Host/TaskPool.h
include/lldb/Utility/TaskPool.h
lldb.xcodeproj/project.pbxproj
fjricci reopened this revision.
fjricci added a comment.
This revision is now accepted and ready to land.
Is ThreadLauncher unavailable in this code for some reason? The link failed on
linux buildbots (building lldb on Darwin was fine locally):
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313537: Use ThreadLauncher to launch TaskPool threads
(authored by fjricci).
Changed prior to commit:
https://reviews.llvm.org/D37930?vs=115484=115658#toc
Repository:
rL LLVM
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
Comment at: source/Utility/TaskPool.cpp:61
+lldb_private::ThreadLauncher::LaunchThread("task-pool.worker", WorkerPtr,
+ this, nullptr, 8 * 1024 * 1024)
fjricci created this revision.
This allows for the stack size to be configured, which isn't
possible with std::thread. Prevents overflowing the stack when
performing complex operations in the task pool on darwin,
where the default pthread stack size is only 512kb.
