This revision was automatically updated to reflect the committed changes.
Closed by commit rL320345: MainLoop: avoid infinite loop when pty slave gets
closed (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D41008
Files:
lldb/trunk/source/Host/common/MainLoop.cpp
labath added a comment.
Darwin uses a kqueue-based implementation of this, so it definitely won't
*break* anything, although I'd appreciate it if you can check whether the test
passes there. My cursory reading of the kqueue man page makes me believe it
should not be affected by this.
davide added subscribers: jingham, davide.
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM. @jingham ? I'll try this change on macOS to make sure it won't break
anything.
https://reviews.llvm.org/D41008
labath created this revision.
For ptys (at least on Linux), the end-of-file (closing of the slave FD)
is signalled by the POLLHUP flag. We were ignoring this flag, which
meant that when this happened, we would spin in a loop, continuously
calling poll(2) and not making any progress.
This makes
