This revision was automatically updated to reflect the committed changes.
Closed by commit rL320984: llgs: Propagate the environment when launching the
inferior from command line (authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41070?vs=126367=127349#toc
clayborg added a comment.
No worries then. No need to make a new enum if this is just two places and they
aren't all setting the same flags.
https://reviews.llvm.org/D41070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h:46
- //--
- /// Specify the program to launch and its arguments.
- ///
- /// @param[in] args
-
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Anything that launches a process should use the ProcessLaunchInfo. Nice patch.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h:46
-
labath created this revision.
Herald added a subscriber: mgorny.
We were failing to propagate the environment when lldb-server was
started with a pre-loaded process
(e.g.: lldb-server gdbserver -- inferior --inferior_args)
This patch makes sure the environment is propagated. Instead of adding a
