Re: [Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

2018-01-29 Thread Davide Italiano via lldb-commits
On Mon, Jan 29, 2018 at 9:42 AM, David Blaikie via lldb-commits wrote: > Any chance of using unique_ptr or other RAII/etc ownership to make this API > safer by default? > I agree that would be a more robust way of dealing with the problem. Thanks, -- Davide

Re: [Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

2018-01-29 Thread David Blaikie via lldb-commits
Any chance of using unique_ptr or other RAII/etc ownership to make this API safer by default? On Mon, Jan 22, 2018 at 10:58 AM Raphael Isemann via Phabricator via llvm-commits wrote: > This revision was not accepted when it landed; it landed in state "Needs >

[Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

2018-01-22 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323138: Fix memory leak in TestClangASTContext.TestRecordHasFields (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [PATCH] D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields

2018-01-22 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. We can't use unique_ptr's here because we use those variables as `out` parameters to some functions. Discovered by the memory sanitizer. https://reviews.llvm.org/D42386 Files: unittests/Symbol/TestClangASTContext.cpp Index: