This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327750: [DWARFASTParserClang] Complete external record types
before using them as a… (authored by friss, committed by ).
H
jingham accepted this revision.
jingham added a comment.
I can't see a narrower way to do this. This sort of change makes me really
wish we had "how many dies did you complete" metrics and some stress tests, so
we can tell if we've just made some operation unreasonably more expensive and
have
clayborg added a comment.
Much better. Make sure Jim is ok with this as I am ok with it if he is.
https://reviews.llvm.org/D43592
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
friss updated this revision to Diff 138734.
friss added a comment.
Adding back a hunk I didn't mean to delete.
https://reviews.llvm.org/D43592
Files:
packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py
packages/Python/lldbsuite/test/lang/cpp/gmodules/main.cpp
packa
friss updated this revision to Diff 138733.
friss added a comment.
I experimented quite a bit with different approches to fix this bug
without always completing the types right after importing them from
the external AST.
This is the most principled approach I came up with. I applied the
new helpe
friss added a comment.
Note that this code path is only triggered when importing debug info from a
different AST context, it is not the common codepath. The issue in this case is
that LLDB is crashing when using the incomplete Decl as the DeclContext for
another one. I guess I could add calls t
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Sean was the person with the most experience working on the expression parser
and he wrote the clang AST importer, but Jim is now the expression parser
expert. Jim: and ideas on
friss created this revision.
friss added a reviewer: clayborg.
Herald added subscribers: JDevlieghere, aprantl.
The modified test would just crash without the code change. The reason is that
we would try to extend the Foo type imported from the PCH debug info when
adding the
Foo::Bar definitiion
