[Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL331315: Fix the .experimental. settings feature so that we dont return an error (authored by jmolenda, committed by ).

Re: [Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

On Fri, 6 Apr 2018 at 23:36, Jason Molenda wrote: > > > > On Apr 6, 2018, at 2:07 AM, Pavel Labath via Phabricator < > revi...@reviews.llvm.org> wrote: > > > > labath added inline comments. > > > > > > > > Comment at: >

[Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

jasonmolenda updated this revision to Diff 141473. jasonmolenda added a comment. rewrote the test cases in terms of self.expect. Haven't looked at being totally correct with flagging paths with .experimental. as never-errored. https://reviews.llvm.org/D45348 Files:

Re: [Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

> On Apr 6, 2018, at 2:07 AM, Pavel Labath via Phabricator > wrote: > > labath added inline comments. > > > > Comment at: packages/Python/lldbsuite/test/settings/TestSettings.py:544-545 > +# the actual name and via .experimental. > +

[Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

labath added inline comments. Comment at: packages/Python/lldbsuite/test/settings/TestSettings.py:544-545 +# the actual name and via .experimental. +cmdinterp.HandleCommand("settings set target.arg0 first-value", result) +

[Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: llvm-commits. setting paths that include .experimental. are intended for settings that may be promoted to "real" settings in the future, or may be removed.