[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl added a comment. As Greg suspected, the problem was that target was null. I rewrote that patch to not use a SymbolContext in the first place. Repository: rL LLVM https://reviews.llvm.org/D46362 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl added a comment. Yes, I must have added a mistake in my last edit before landing this. I reverted that patch for now. Repository: rL LLVM https://reviews.llvm.org/D46362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

labath added a comment. It looks like this has caused a bunch of tests to crash on linux http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/22800. The crashes seem to be happening during printing of global variables ( `HandleCommand(command = "target variable

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

This revision was automatically updated to reflect the committed changes. Closed by commit rL331462: DWARFExpression: Convert file addresses to load addresses early on. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl updated this revision to Diff 145032. aprantl added a comment. Thanks for the excellent feedback! Addressed comments. https://reviews.llvm.org/D46362 Files: include/lldb/Core/Value.h source/Core/Value.cpp source/Core/ValueObjectVariable.cpp source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. great fix. Just resolve the file address using the module function and this is good to go. Comment at: source/Core/Value.cpp:683-685 + ObjectFile *objfile =

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

labath added a comment. One day I'd like us to have a unit testing framework for the dwarf expression evaluator. The evaluator looks like a thing that is both complex enough (so it's worth doing it) and /ought to be/ self-contained enough (so it is doable). Then we could test these, and all

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl created this revision. aprantl added a reviewer: clayborg. Herald added a subscriber: JDevlieghere. This is a change that only affects Swift and is NFC for the language plugins on llvm.org. In Swift, we can have global variables with a location such as DW_OP_addr DW_OP_deref. The DWARF