[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBasicDIE as compile-time protection

clayborg added a comment. Rename to DWARFBaseDIE and this is good to go. https://reviews.llvm.org/D47276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBasicDIE as compile-time protection

jankratochvil updated this revision to Diff 148362. https://reviews.llvm.org/D47276 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.h source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBasicDIE as compile-time protection

clayborg added a comment. Waiting for answers on renaming from patch 1/3 before commenting. https://reviews.llvm.org/D47276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBasicDIE as compile-time protection

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. Herald added subscribers: JDevlieghere, aprantl. As suggested by Pavel Labath in https://reviews.llvm.org/D46810 `DWARFUnit::GetUnitDIEOnly()` returning a pointer to `m_first_die` should not permit using