This revision was automatically updated to reflect the committed changes.
Closed by commit rL333444: Remove lldb-private headers when building
LLDB.framework with CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
xiaobai updated this revision to Diff 148688.
xiaobai added a comment.
Updating to reflect changes in r04
https://reviews.llvm.org/D47278
Files:
source/API/CMakeLists.txt
Index: source/API/CMakeLists.txt
===
---
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110777, @labath wrote:
> From a layering perspective, it makes sense for SystemInitializerFull to live
> in the outermost layer, as it's the thing which makes sure liblldb pulls in
> all required components. Since it is only included
labath added a comment.
From a layering perspective, it makes sense for SystemInitializerFull to live
in the outermost layer, as it's the thing which makes sure liblldb pulls in all
required components. Since it is only included from files in `source/API`
(which is as it should be), maybe we
clayborg added a comment.
The issue is actually that SystemInitializerFull.h and
SystemInitializerFull.cpp are in the wrong directories. They belong in the
"lldb/Initialization" and "Source//Initialization". We should fix this and then
some/all of your changes won't be needed?
xiaobai updated this revision to Diff 148305.
xiaobai added a comment.
Remove SystemInitializerFull.h from framework headers
https://reviews.llvm.org/D47278
Files:
source/API/CMakeLists.txt
Index: source/API/CMakeLists.txt
===
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110171, @clayborg wrote:
> In https://reviews.llvm.org/D47278#1110164, @xiaobai wrote:
>
> > In https://reviews.llvm.org/D47278#1110155, @clayborg wrote:
> >
> > > sorry, not as a test, but just as a way to figure out if we are getting
clayborg added a comment.
In https://reviews.llvm.org/D47278#1110164, @xiaobai wrote:
> In https://reviews.llvm.org/D47278#1110155, @clayborg wrote:
>
> > sorry, not as a test, but just as a way to figure out if we are getting all
> > the needed header files when we modify this framework header
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110155, @clayborg wrote:
> sorry, not as a test, but just as a way to figure out if we are getting all
> the needed header files when we modify this framework header file copying
> code.
Ah, yeah. I'm in the process of trying to
clayborg added a comment.
sorry, not as a test, but just as a way to figure out if we are getting all the
needed header files when we modify this framework header file copying code.
https://reviews.llvm.org/D47278
___
lldb-commits mailing list
xiaobai added a comment.
In https://reviews.llvm.org/D47278#1110104, @clayborg wrote:
> That is the only guaranteed way as new headers could come along.
> LLDB.framework doesn't have headers in installed Xcode.app bundles
In that case, adding this test could double build times since we would
clayborg added a comment.
In https://reviews.llvm.org/D47278#1110092, @xiaobai wrote:
> I also think that'd be a great idea. The only way I can think to do that
> would be to build LLDB.framework using both build systems and compare the
> two. Is there a faster way?
That is the only
xiaobai added a comment.
I also think that'd be a great idea. The only way I can think to do that would
be to build LLDB.framework using both build systems and compare the two. Is
there a faster way?
https://reviews.llvm.org/D47278
___
clayborg added a comment.
It would be good to verify all headers that are in the LLDB.framework produced
by Xcode builds are also in the LLDB.framework from cmake/ninja
https://reviews.llvm.org/D47278
___
lldb-commits mailing list
xiaobai created this revision.
xiaobai added reviewers: compnerd, sas, labath, beanz, zturner.
Herald added a subscriber: mgorny.
Generating LLDB.framework when building with CMake+Ninja will copy the
lldb-private headers because public_headers contains them, even though we try
to make sure they
15 matches
Mail list logo
