This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333697: [IRMemoryMap] Fix the alignment adjustment in Malloc
(authored by vedantk, committed by ).
Herald added a
vsk updated this revision to Diff 149355.
vsk marked 2 inline comments as done.
vsk added a comment.
- Address Pavel's feedback, remove a questionable FIXME.
https://reviews.llvm.org/D47551
Files:
lit/Expr/Inputs/ir-memory-map-basic.test
lit/Expr/Inputs/ir-memory-map-overlap1.test
vsk added a comment.
In https://reviews.llvm.org/D47551#1117086, @lhames wrote:
> LGTM.
>
> I haven't looked at process memory management. How hard would your FIXME be
> to implement?
After looking at this more carefully, I think the FIXME makes a bad
prescription. It's based on the
labath added a comment.
I don't know much about IRMemoryMap myself, but this does seem uncontroversial.
Nonetheless, I did manage to find something to rip into. :D
Comment at: source/Expression/IRMemoryMap.cpp:312-316
+// Round up the requested size to an aligned value,
lhames added a comment.
LGTM.
I haven't looked at process memory management. How hard would your FIXME be to
implement?
- Lang.
https://reviews.llvm.org/D47551
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk updated this revision to Diff 149198.
vsk added a reviewer: lhames.
vsk added a comment.
- Don't insert extra padding bytes when `alignment` = 1.
- + Lang
https://reviews.llvm.org/D47551
Files:
lit/Expr/Inputs/ir-memory-map-basic.test
lit/Expr/Inputs/ir-memory-map-overlap1.test
vsk created this revision.
vsk added reviewers: labath, zturner, jingham, aprantl.
vsk edited the summary of this revision.
This prevents Malloc from allocating the same chunk of memory twice, as
a byproduct of an alignment adjustment which gave the client access to
unallocated memory.
Prior to
