[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

probinson added a comment. In D49466#1761156 , @MaskRay wrote: > The ugly path separator pattern `{{(/|)}}` appears in 60+ tests. Can we > teach clang and other tools to > > 1. accept both `/` and `\` input In general they do, AFAIK, although it's

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

thakis added a comment. There's still one failing test on Windows after the fix attempt: http://45.33.8.238/win/3052/step_6.txt Please take a look and revert if it's not an easy fix. (And please watch bots after committing stuff.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. The ugly path separator pattern `{{(/|)}}` appears in 60+ tests. Can we teach clang and other tools to 1. accept both `/` and `\` input 2. but only output `/` on Windows? We can probably remove `llvm::sys::path::Style::{windows,posix,native}` from

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. Does this work on Windows? --- i/clang/test/Preprocessor/file_test.c +++ w/clang/test/Preprocessor/file_test.c @@ -1,8 +1,7 @@ -// XFAIL: system-windows // RUN: %clang -E -ffile-prefix-map=%p=/UNLIKELY_PATH/empty -c -o - %s | FileCheck %s // RUN: %clang -E

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay updated this revision to Diff 231142. MaskRay added a comment. Minimize diff in Options.td Properly rebase remapDIPath on top of D69213 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay updated this revision to Diff 231140. MaskRay added a comment. Add back remapDIPath that was unintentionally deleted by D69213 , caught by a test. Small adjustment of the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. In D49466#1761044 , @thakis wrote: > There's still one failing test on Windows after the fix attempt: > http://45.33.8.238/win/3052/step_6.txt > > Please take a look and revert if it's not an easy fix. (And please watch bots >

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1760860 , @MaskRay wrote: > Add back remapDIPath that was unintentionally deleted by D69213 > , caught by a test. > > Small adjustment of the code Right. Can't believe I missed that.

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c92cdff7225: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map (authored by dankm, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. In D49466#1760765 , @dankm wrote: > Ping? The tests need fixing... I can commit it. Now that we've migrated to the llvm monorepo, the git commit message can retain the author info properly... Repository: rG LLVM Github

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. Whoops. There are extra changes here I didn't mean to submit :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 229835. dankm added a comment. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. - Address feedback from @Lekensteyn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1681534 , @phosek wrote: > @dankm is it OK if we take over this change to push it forward? At this point sure. Unless it's accepted as-is now, then I don't have a commit bit to finish it off. Repository: rG LLVM

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 229837. dankm added a comment. - Address feedback from @Lekensteyn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files: