On Wed, Aug 22, 2018 at 12:34 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a subscriber: labath.
> aleksandr.urakov added a comment.
>
> It seems that the cause of the failure is
> https://reviews.llvm.org/rL340206, but I'm not sure if the adding
aleksandr.urakov added a subscriber: labath.
aleksandr.urakov added a comment.
It seems that the cause of the failure is https://reviews.llvm.org/rL340206,
but I'm not sure if the adding of `-gpubnames` switch to `clang` will be a
correct fix for that?
Repository:
rL LLVM
stella.stamenova added a comment.
In https://reviews.llvm.org/D49980#1208096, @aleksandr.urakov wrote:
> It's also possible that the test has been failing since some commit in
> another repository (e.g. `clang`, `lld` or `llvm`). It seems that it was ok
> several days ago...
I think you are
aleksandr.urakov added a comment.
It's also possible that the test has been failing since some commit in another
repository (e.g. `clang`, `lld` or `llvm`). It seems that it was ok several
days ago...
Repository:
rL LLVM
https://reviews.llvm.org/D49980
aleksandr.urakov added a comment.
Yes, I've seen today that this test is failing now, but if I'm not mistaken
this have happened some later than this patch was committed. But I'm not sure,
I'll look at this more precisely tomorrow, thanks!
Repository:
rL LLVM
stella.stamenova added a comment.
I am not 100% sure yet, but this change is the most likely culprit for one of
the SymbolFile tests to start failing, namely:
SymbolFile/DWARF/dwarf5-index-is-used.cpp. This fails for us on both Windows
and Linux with the following:
FAIL: lldb ::
aleksandr.urakov added a comment.
Thanks for catching that!
I didn't know about that warnings because I build LLVM with MSVC compiler, but
it doesn't introduce such warnings. Now I've fixed the problem with
https://reviews.llvm.org/rLLDB339994.
Repository:
rL LLVM
teemperor added a comment.
@aleksandr.urakov Not sure if you are already working of this, but just FYI
this patch introduced a few compiler warnings:
/Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:55:3:
warning: default label in switch which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339649: [PDB] Parse UDT symbols and pointers to members
(combined patch) (authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aleksandr.urakov added a comment.
Thanks a lot!
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Ok I’ll take a look later today then when i get in
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Ok I’ll take a look later today then when i get in
On Mon, Aug 13, 2018 at 2:13 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> Unfortunately, there was no people yet, who can review this :)
>
> Ping! Can anyone review this, please?
>
aleksandr.urakov added a comment.
Unfortunately, there was no people yet, who can review this :)
Ping! Can anyone review this, please?
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
I am OOO this week and only have access to mobile, so hopefully someone
else can review it
On Mon, Aug 6, 2018 at 11:05 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> Ping!
>
> Can you review this, please?
>
>
>
zturner added a subscriber: aleksandr.urakov.
zturner added a comment.
I am OOO this week and only have access to mobile, so hopefully someone
else can review it
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
aleksandr.urakov added a comment.
Ping!
Can you review this, please?
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov updated this revision to Diff 158194.
aleksandr.urakov added a comment.
Added support of a MSInheritance attribute.
https://reviews.llvm.org/D49980
Files:
include/lldb/Symbol/ClangASTContext.h
lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
aleksandr.urakov added inline comments.
Comment at: lit/SymbolFile/PDB/udt-layout.test:1-51
+REQUIRES: windows
+RUN: clang-cl /Zi %S/Inputs/UdtLayoutTest.cpp /o %t.exe
+RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s
+
+CHECK:(int) int C::abc = 123
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: asmith, zturner, rnk, labath, clayborg,
lldb-commits.
Herald added a subscriber: JDevlieghere.
In this patch I've tried to combine the best ideas from
https://reviews.llvm.org/D49368 and https://reviews.llvm.org/D49410,
19 matches
Mail list logo
