clayborg added a comment.
More offsetof issues:
$ svn commit
Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
Transmitting file data .done
Committing transaction...
Committed revision 339034.
Repository:
rL LLVM
https://reviews.llvm.org/D50336
clayborg added a comment.
Passing patches between linux and mac the offsetof fixes got lost. When binary
files are involved, patches are trickier to pass between to machines.
Repository:
rL LLVM
https://reviews.llvm.org/D50336
___
lldb-commits
clayborg added a comment.
Fixed offsetof issues with:
$ svn commit
Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp
Transmitting file data ..done
Committing transaction...
Committed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339032: Add support for ARM and ARM64 breakpad generated
minidump files (version 2). (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB339032: Add support for ARM and ARM64 breakpad generated
minidump files (version 2). (authored by gclayton, committed by ).
Changed prior to commit:
clayborg updated this revision to Diff 159324.
clayborg added a comment.
Herald added a subscriber: mgorny.
Added CMakeList.txt changes, tested on linux, and removed unused "log" variable.
https://reviews.llvm.org/D50336
Files:
include/lldb/Target/Target.h
lldb.xcodeproj/project.pbxproj
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This should be fine once the cmake thing is addressed.
https://reviews.llvm.org/D50336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
I was in the process of testing on linux. I will fix this.
> On Aug 6, 2018, at 8:19 AM, Zachary Turner wrote:
>
> Did you see my comments on the first round about how the CMake build didn’t
> work? Because I don’t see any changes to CMakeLists.txt here, which means it
> still won’t work.
>
zturner added a subscriber: clayborg.
zturner added a comment.
Did you see my comments on the first round about how the CMake build didn’t
work? Because I don’t see any changes to CMakeLists.txt here, which means
it still won’t work.
The easiest way to make sure you get all the fixes that may
Did you see my comments on the first round about how the CMake build didn’t
work? Because I don’t see any changes to CMakeLists.txt here, which means
it still won’t work.
The easiest way to make sure you get all the fixes that may have gone in
after your initial commit is to revert the revert and
clayborg created this revision.
clayborg added reviewers: labath, zturner, markmentovai, javed.absar.
Herald added subscribers: chrib, kristof.beyls.
In this patch I add support for ARM and ARM64 break pad files. There are two
flavors of ARM: Apple where FP is
11 matches
Mail list logo
