[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339669: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the… (authored by stefan.graenitz, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. https://reviews.llvm.org/D50536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: source/Utility/ConstString.cpp:123-126 + assert((map.find(demangled) == map.end() || strlen(map[demangled]) == 0 || + map[demangled] == mangled_ccstr) && +

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz updated this revision to Diff 160143. sgraenitz added a comment. Move assert after try_emplace https://reviews.llvm.org/D50536 Files: source/Utility/ConstString.cpp unittests/Utility/ConstStringTest.cpp Index: unittests/Utility/ConstStringTest.cpp

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

friss added inline comments. Comment at: source/Utility/ConstString.cpp:123-126 + assert((map.find(demangled) == map.end() || strlen(map[demangled]) == 0 || + map[demangled] == mangled_ccstr) && + "The demangled string must have a unique

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz updated this revision to Diff 160014. sgraenitz added a comment. Show allowed cases in ConstStringTest.UpdateMangledCounterpart and format https://reviews.llvm.org/D50536 Files: source/Utility/ConstString.cpp unittests/Utility/ConstStringTest.cpp Index:

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz created this revision. sgraenitz added reviewers: jingham, friss, labath. This issue came up because it caused problems in our unit tests. The StringPool did connect counterparts only once and silently ignored the values passed in subsequent calls. The simplest solution for the unit