[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340988: Dont cancel the current IOHandler when we push a handler for an utility… (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D50912 Files:

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This is fine by me. https://reviews.llvm.org/D50912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

clayborg added a comment. Sounds good. I am ok with this as long as Jim Ingham is. https://reviews.llvm.org/D50912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor updated this revision to Diff 162238. teemperor added a comment. - Add an assert against underflow checking. - Fixed a (serious) typo that broke the test. https://reviews.llvm.org/D50912 Files: include/lldb/Core/Debugger.h include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor added inline comments. Comment at: source/Target/Process.cpp:4696-4697 +// the IOHandler for Editline). +bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction(); +GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler); return

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor updated this revision to Diff 162227. teemperor added a comment. Herald added a subscriber: emaste. I added an flag for this to the evaluation options. I also set this flag for all utility calls I found. https://reviews.llvm.org/D50912 Files: include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

jingham added a comment. It's not a huge deal, but it would be disconcerting to have a bunch of text dumped to your console the next time you continue. I think the ideal solution would be for utility functions to push a "capture & report" IO handler, so the Utility function could retrieve

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

clayborg added a comment. In https://reviews.llvm.org/D50912#1209994, @jingham wrote: > What would happen to any output that the process produced while running the > utility function if we did this. I believe it would still be fetched on next stop. Just not real time. Do you think anyone

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

jingham added a comment. What would happen to any output that the process produced while running the utility function if we did this. https://reviews.llvm.org/D50912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

clayborg added inline comments. Comment at: source/Target/Process.cpp:4692-4693 +// the IOHandler for Editline). +bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction(); +GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler); return

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

jingham added a comment. m_last_natural_stop_id is the stop ID for the last time we stopped when the user was just running the process (run, continue, next, etc...) m_last_user_expression_resume is the resume ID for the last user expression resume. The stops and resumes always occur in pairs

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor added inline comments. Comment at: include/lldb/Target/Process.h:435 + bool IsRunningUtilityFunction() const { +return m_last_natural_stop_id != m_stop_id; + } @jingham That might be wrong, but I'm not sure what exactly each member variable is

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor updated this revision to Diff 161829. teemperor retitled this revision from "Don't cancel the current IOHandler when we push the ProcessIO handler." to "Don't cancel the current IOHandler when we push a handler for an utility function run.". teemperor edited the summary of this