This revision was automatically updated to reflect the committed changes.
Closed by commit rL341296: [DWARF] Fix dwarf5-index-is-used.cpp (authored by
aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aleksandr.urakov added a comment.
Ok, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
As for the original patch, which we've kind of hijacked, I think it is a good
idea to commit this for now.
Once the clang patch is in, I'll exchange these flags for -glldb.
Repository:
labath added a comment.
In https://reviews.llvm.org/D51208#1214743, @dblaikie wrote:
> >> But if LLDB has different performance characteristics, or the default
> >> should be different for other reasons - I'm fine with that. I think I left
> >> it on for Apple so as not to mess with their
On Tue, Aug 28, 2018 at 7:33 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a comment.
>
> In https://reviews.llvm.org/D51208#1214743, @dblaikie wrote:
>
> > >> But if LLDB has different performance characteristics, or the default
> should be different for
clayborg added a comment.
In https://reviews.llvm.org/D51208#1214743, @dblaikie wrote:
> >> But if LLDB has different performance characteristics, or the default
> >> should be different for other reasons - I'm fine with that. I think I left
> >> it on for Apple so as not to mess with their
dblaikie added a comment.
>> But if LLDB has different performance characteristics, or the default should
>> be different for other reasons - I'm fine with that. I think I left it on
>> for Apple so as not to mess with their stuff because of the MachO/dsym sort
>> of thing that's a bit
labath added a subscriber: probinson.
labath added a comment.
In https://reviews.llvm.org/D51208#1212950, @dblaikie wrote:
> In https://reviews.llvm.org/D51208#1212320, @labath wrote:
>
> > As far as the strict intention of this test goes, the change is fine, as it
> > is meant to check that
dblaikie added a comment.
Herald added a subscriber: teemperor.
In https://reviews.llvm.org/D51208#1212320, @labath wrote:
> As far as the strict intention of this test goes, the change is fine, as it
> is meant to check that the accelerator tables get used *when* they are
> generated. How do
labath added a comment.
As far as the strict intention of this test goes, the change is fine, as it is
meant to check that the accelerator tables get used *when* they are generated.
How do you achieve them being generated is not important.
However, I am not sure now under what circumstances
10 matches
Mail list logo
