This revision was automatically updated to reflect the committed changes.
Closed by commit rL347869: [CMake] Fix standalone build for debugserver on
macOS (authored by stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
sgraenitz added a comment.
Thought about it, but yes, at the moment it looks like overkill. I'd go on
duplicating options to debugserver for now and change the approach if it gets
unpractical. There are some more changes to come. I want to upstream these
first and see how it looks then.
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
This change looks fine to me. Have you considered creating something like a
"debugserverStandalone.cmake" file similar to how LLDB standalone builds work?
Might save us from some
sgraenitz created this revision.
sgraenitz added reviewers: xiaobai, beanz.
Herald added a subscriber: mgorny.
Quick-fix to avoid CMake config issue:
CMake Error at /path/to/lldb/cmake/modules/AddLLDB.cmake:116
(add_dependencies):
Cannot add target-level dependencies to non-existent