[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

2019-03-25 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356911: Update the lldb driver to support the -O and -S options when passing --repl (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D59681?vs=191904=192116#toc

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

2019-03-22 Thread Nathan Hawes via Phabricator via lldb-commits
nathawes updated this revision to Diff 191904. nathawes added a comment. Updated the test based on feedback from @aprantl and also to specifically check we don't see the output from the -o and -s commands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59681/new/

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

2019-03-22 Thread Nathan Hawes via Phabricator via lldb-commits
nathawes marked an inline comment as done. nathawes added inline comments. Comment at: lldb/lit/Driver/TestRepl.test:2 +# RUN: echo ':quit' | %lldb -x --repl -O 'expr 42' -S %S/Inputs/Print2.in -o 'expr something invalid' -s %s 2>&1 | FileCheck %s +# CHECK: warning: commands

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

2019-03-22 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! LGTM with one tiny change to the test. Comment at: lldb/lit/Driver/TestRepl.test:2 +# RUN: echo ':quit' | %lldb -x --repl -O 'expr 42' -S %S/Inputs/Print2.in -o

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

2019-03-21 Thread Nathan Hawes via Phabricator via lldb-commits
nathawes created this revision. nathawes added reviewers: aprantl, jingham. Herald added a subscriber: abidh. Herald added a project: LLDB. At the moment when `--repl` is passed to `lldb` it silently ignores any commands passed via the options below: --one-line-before-file