[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

mgorny added a comment. In D61713#1502606 , @labath wrote: > In D61713#1502580 , @mgorny wrote: > > > Is this test supposed to work portably? It fails on NetBSD buildbot: > >

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath added a comment. In D61713#1502580 , @mgorny wrote: > Is this test supposed to work portably? It fails on NetBSD buildbot: >

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath added a comment. In D61713#1502617 , @mgorny wrote: > In D61713#1502606 , @labath wrote: > > > In D61713#1502580 , @mgorny wrote: > > > > > Is this test supposed to

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL360355: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe updated this revision to Diff 198858. jgorbe added a comment. Removed trailing blank lines from test case, will commit now. Thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713 Files:

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath accepted this revision. labath added a comment. Awesome, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe updated this revision to Diff 198853. jgorbe added a comment. Added a new test that checks that, when a full path to a compiler is specified: - That compiler is used in build commands - The flag style used in build commands matches the toolchain type autodetected from the compiler

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath added a comment. BTW, there's some existing tests for build.py in `lit/BuildScript`. Could you check if it's feasible to make an analogous test for the fix you're making here? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe created this revision. jgorbe added reviewers: labath, zturner. Herald added a subscriber: teemperor. Herald added a project: LLDB. All the other paths in the find_toolchain function return a tuple (detected_toolchain_type, compiler_path), but when the parameter to `--compiler` is not