This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361618: [FuncUnwinders] Use symbol file
unwind plans for unwinding (authored by labath, committed by ).
Herald added a project: LLDB.
Changed prior to commit:
labath updated this revision to Diff 200737.
labath added a comment.
- use (reduced) yaml form of the minidump now that yaml2obj supports memory
regions
- move the symbol file unwind plan to the top of the list. I agree with the
reasoning behind this and with the debug_frame>eh_frame (which
clayborg added inline comments.
Comment at: source/Symbol/FuncUnwinders.cpp:63-64
return plan_sp;
if (UnwindPlanSP plan_sp = GetDebugFrameUnwindPlan(target))
return plan_sp;
if (UnwindPlanSP plan_sp = GetCompactUnwindUnwindPlan(target))
We should
labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Symbol/FuncUnwinders.cpp:61-70
if (UnwindPlanSP plan_sp = GetEHFrameUnwindPlan(target))
return plan_sp;
if (UnwindPlanSP plan_sp = GetDebugFrameUnwindPlan(target))
return
clayborg added inline comments.
Comment at: source/Symbol/FuncUnwinders.cpp:61-70
if (UnwindPlanSP plan_sp = GetEHFrameUnwindPlan(target))
return plan_sp;
if (UnwindPlanSP plan_sp = GetDebugFrameUnwindPlan(target))
return plan_sp;
if (UnwindPlanSP plan_sp =
labath created this revision.
labath added reviewers: jasonmolenda, clayborg.
Previous patch (r360409) introduced the "symbol file unwind plan"
concept, but that plan wasn't used for unwinding yet. With this patch,
we start to consider the new plan as a possible strategy for both
synchronous and
