[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

This revision was automatically updated to reflect the committed changes. Closed by commit rL364035: [unittests] Simplify CMakeLists with object library (authored by tkrasnukha, committed by ). Changed prior to commit: https://reviews.llvm.org/D63544?vs=205816=205971#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

tatyana-krasnukha reopened this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. @beanz you're absolutely right, thank you. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/ https://reviews.llvm.org/D63544

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

beanz added a comment. I really don't think this is the right solution. `$` can be passed in as source files in the unit test target, which should work just fine on CMake 3.4.x. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

This revision was automatically updated to reflect the committed changes. Closed by commit rL363933: [unittests] Use object library if cmake supports it (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

hintonda accepted this revision. hintonda added a comment. In D63544#1551939 , @tatyana-krasnukha wrote: > Finally updated versions - `target_sources` supports using > `$` since CMake 3.5.0. Great, thanks for narrowing that down, Still LGTM!

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

tatyana-krasnukha updated this revision to Diff 205800. tatyana-krasnukha added a comment. Finally updated versions - `target_sources` supports using `$` since CMake 3.5.0. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

tatyana-krasnukha updated this revision to Diff 205648. tatyana-krasnukha retitled this revision from "Add a worlaround for unsupported cmake feature" to "Use object library if cmake supports it". tatyana-krasnukha added a comment. As I figured out, cmake allows to use $ anywhere since version