[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

This revision was automatically updated to reflect the committed changes. Closed by commit rL365761: [LLDB] Fix FreeBSD build. (authored by devnexen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I think the description should mention that this is to fix FreeBSD build after the LaunchThread interface change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

MaskRay added a comment. In D64398#1575713 , @devnexen wrote: > By the way quick question, I did not commit since quite a time, is it still > subversion ? Many people switched to the git monorepo github.com/llvm/llvm-project && `git llvm push` (I

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen added a comment. By the way quick question, I did not commit since quite a time, is it still subversion ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen updated this revision to Diff 208649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.h Index:

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:798 + if (!m_operation_thread) { + Status e("Start launch thread failed"); + error = e; MaskRay wrote: > See

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

MaskRay added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:798 + if (!m_operation_thread) { + Status e("Start launch thread failed"); + error = e; See D64163/r365226 Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen created this revision. devnexen added reviewers: mgorny, MaskRay. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, jfb, emaste. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D64398 Files: