[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath added a comment. It took me a while, but I tracked this down to the lack of `%` in front of lldb in the RUN: commands. We don't have an "lldb" substitution, so this ends up running whatever it finds on the path. Normally this does not matter because we add the build dir to the lit path,

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

JDevlieghere added a comment. I'm seeing some really weird behavior for the following two tests and I'm honestly kind of puzzled. ObjectFile/ELF/PT_LOAD-overlap-PT_TLS.yaml ObjectFile/ELF/PT_TLS-overlap-PT_LOAD.yaml They fail in the same way for a standalone build, both on macOS

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rL368010: ObjectFileELF: permit thread-local sections with overlapping file addresses (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath added a comment. Thanks for sharing your knowledge about linkers and dynamic loaders. I have found it very useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D65282#1602293 , @labath wrote: > In D65282#1602244 , @MaskRay wrote: > > > > Are you referring to the

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath updated this revision to Diff 211904. labath added a comment. Split the test into two CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 Files: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml lit/Modules/ELF/PT_TLS-overlap-PT_LOAD.yaml

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath marked 2 inline comments as done. labath added a comment. In D65282#1602244 , @MaskRay wrote: > > Are you referring to the "image lookup" command specifically, or is it a > > more general question about the internals of lldb too? > > Both:) This

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added inline comments. Comment at: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml:62 +Flags: [ SHF_ALLOC, SHF_WRITE ] +Address: 0x1000 +AddressAlign:0x4 `.data = .tbss = 0x1010` is a more realistic scenario. Normally, a

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added a comment. > Are you referring to the "image lookup" command specifically, or is it a more > general question about the internals of lldb too? Both:) This patch doesn't change the `Address: a.o[0x1010] (a.o.PT_LOAD[0]..tdata + 0)` output so I was puzzled what this patch

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath updated this revision to Diff 211899. labath marked 3 inline comments as done. labath added a comment. - update according to review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 Files:

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath marked an inline comment as done. labath added a comment. > Do you mind explaining more how you'd like to improve file-address-based > lookups for PT_TLS? I don't have this fully thought through (I was hoping this would develop as use cases start showing up), but... Are you referring

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added inline comments. Comment at: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml:44 +# LOOKUP-LABEL: image lookup -a 0x1010 +# LOOKUP: Address: {{.*}}.PT_LOAD[0]..data + 16) + Do you mind explaining more how you'd like to improve file-address-based

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added a comment. > It turns out this was too aggressive because thread-local sections typically will have file addresses which apear to overlap regular data/code. This does not cause a problem at runtime because thread-local sections are loaded into memory using special logic, but it can

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1874-1875 -ConstString Name(("PT_LOAD[" + llvm::Twine(LoadID++) + "]").str()); +ConstString Name(llvm::formatv("{0}[{1}]", provider.GetSegmentName(), +