[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: lldb/docs/resources/build.rst:90 + + > git clone https://github.com/llvm/llvm-project.git sgraenitz wrote: > jryans wrote: > > This could be done in a separate patch, but

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

This revision was automatically updated to reflect the committed changes. Closed by commit rL367302: [lldb][docs] Update documentation for monorepo and CMake caches (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 212304. sgraenitz added a comment. Add lld note to Windows section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files: lldb/docs/resources/build.rst Index:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova accepted this revision. stella.stamenova added a comment. I think you need one small change for lld still - to make it clear that it is required on Windows in the Windows section, but it looks good otherwise. Please fix that before committing. Comment at:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

labath accepted this revision. labath added a comment. Thanks for putting this together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 ___ lldb-commits

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. Thanks for your feedback. In D65330#1604355 , @labath wrote: > lld is required for running the (dotest) test suite on windows. On other > platforms it is not required, but there are tests which will only get run if > lld is

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

labath added a comment. If we're going to be mentioning test dependencies, then it probably makes sense to mention lld too. AFAIK, lld is required for running the (dotest) test suite on windows. On other platforms it is not required, but there are tests which will only get run if lld is

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. Current version looks great to me!  Comment at: lldb/docs/resources/build.rst:90 + + > git clone https://github.com/llvm/llvm-project.git This could be done in a separate patch, but I happened to

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 212052. sgraenitz added a comment. Feedback and polishing; latest rendered output here: http://tiny.cc/i5ncaz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz marked an inline comment as done. sgraenitz added a comment. Hi Greg, thanks for your feedback. > Can we add a section for "Building LLDB with Xcode"? We had a shell script > patch that was going to be checked in, not sure if it made it. But it did a > two part thing where it built

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 212051. sgraenitz marked 11 inline comments as done. sgraenitz added a comment. Address recent feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

clayborg added a comment. Can we add a section for "Building LLDB with Xcode"? We had a shell script patch that was going to be checked in, not sure if it made it. But it did a two part thing where it built LLVM and clang and then generated an Xcode project. I would rather just produce the

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

amccarth added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_.

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_.

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. In D65330#1602786 , @jryans wrote: > On http://releases.llvm.org/, for some recent versions like 8.0.0, the > "Documentation" column has separate versioned links for "llvm clang lld > clang-extra libc++ polly", but lldb

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602779 , @sgraenitz wrote: > Where did you find the //sub-project list of versioned docs//? On http://releases.llvm.org/, for some recent versions like 8.0.0, the "Documentation" column has separate versioned links

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_.

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. In D65330#1602756 , @jryans wrote: > Hmm, are there the LLDB docs archived per release? [...] LLDB doesn't seem to > appear in sub-project list of versioned docs Right, Clang docs are here:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

amccarth added a comment. Looks good. Thanks for doing these updates! Comment at: lldb/docs/resources/build.rst:85 +The LLVM project is migrating to a single monolithic respository for LLVM and +its subprojects. This is the recommended way to build LLDB. Checkout the

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. In D65330#1602737 , @sgraenitz wrote: > I added a few links to LLVM documentation here and wondered what to do with > them, if this gets cherry-picked to `release/9.x`, e.g. >

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602715 , @sgraenitz wrote: > Cool, patch `Diff 211951` has the change. Here's the difference in generated > output: > https://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html > >

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. >> Since //Visual Studio// is the only section in //Building LLDB with CMake >> and Other Generators// now, ... > > Yes, this sounds like a good plan. Cool, patch `Diff 211951` has the change. Here's the difference in generated output:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211951. sgraenitz added a comment. Merge Visual Studio build instructions into `Common CMake options > Windows` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211950. sgraenitz added a comment. Polishing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files: lldb/docs/resources/build.rst Index:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602583 , @sgraenitz wrote: > Since //Visual Studio// is the only section in //Building LLDB with CMake and > Other Generators// now, I would like to: > > - move it merge it with another one, preferably //Common CMake

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. Updated rendered HTML: http://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. Since //Visual Studio// is the only section in //Building LLDB with CMake and Other Generators// now, I would like to: - move it merge it with another one, preferably //Common CMake options > Windows// - rename //Building LLDB with CMake & Ninja// into //Building

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211930. sgraenitz marked an inline comment as done. sgraenitz added a comment. Polish section `Standalone builds` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. This revision is now accepted and ready to land. Great!  Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211931. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Polish section `CMake caches` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In general, this looks great overall! I added few comments on things that would be good to clarify. Comment at: lldb/docs/resources/build.rst:108 +subprojects to build in addition to LLVM. Read more about additional options in +the CMake Options

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211922. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Add links to sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

labath added a comment. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. View rendered HTML output here: http://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

teemperor added a comment. LGTM (beside the standalone build section which I have no experience with). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 ___

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jingham, labath, stella.stamenova, teemperor, jryans, kastiglione. Herald added a project: LLDB. sgraenitz added a subscriber: friss. sgraenitz added reviewers: xiaobai, compnerd. The lldb build system made good progress