[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/source/Host/common/LZMA.cpp:84 + lzma_ret xzerr = lzma_stream_footer_decode( + , InputBuffer.data() + InputBuffer.size() - LZMA_STREAM_HEADER_SIZE); + if (xzerr != LZMA_OK) { kwk wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk closed this revision. kwk added a comment. Closed by 2c082b48274fcba62bf9b3acb63075aedcc7a976 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223482. kwk added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Host/Config.h.cmake

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

jankratochvil added a comment. In D66791#1696340 , @kwk wrote: > lldb-Suite :: commands/process/attach/TestProcessAttach.py > lldb-Suite :: tools/lldb-vscode/attach/TestVSCode_attach.py > These are by: D68289 >

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath as much as I would love to merge this patch I get errors from these tests that I didn't see before. They only appear after rebasing onto master: Failing Tests (4): lldb-Suite :: commands/process/attach/TestProcessAttach.py lldb-Suite ::

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223382. kwk added a comment. Rebased onto current master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I've addressed all you comments. Thank you for answering @jankratochvil's question as well. If this patch is good to go now, please give a thumbs up. Comment at: lldb/source/Host/common/LZMA.cpp:84 + lzma_ret xzerr = lzma_stream_footer_decode( +

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223381. kwk marked 10 inline comments as done. kwk added a comment. - Fix typo: s/a. /a ./ - Fix comment header - Remove redundant input buffer check - Remove another redundant input buffer check - Change variable initialization to assign - added comment about

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath ah, I've just seen that you did accept the revision already. Will merge it then after running tests once more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219038. kwk added a comment. - Fix spelling error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218930. kwk added a comment. Herald added subscribers: wuzish, rnkovacs. - Fixup - Test for minidebuginfo image dump symtab - Fixed test for corrupted xz blob - Fix test - Added test that runs when no LZMA is configured Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218932. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218929. kwk added a comment. Herald added subscribers: openmp-commits, libcxx-commits, Sanitizers, cfe-commits, seiya, erik.pilkington, asbirlea, ormris, Petar.Avramovic, jsji, mstorsjo, jfb, kadircet, arphaman, jkorous, george.burgess.iv, christof,

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218931. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath accepted this revision. labath added a comment. Ok, let's try this once more. I took another look at the patch, and I have some more tiny comments, but nothing too major. I'm sorry this took so long. When the topic of parsing both symbol sections came up, I was happy that it was

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1854 + gdd_objfile_section_list->FindSectionByType( + eSectionTypeELFSymbolTable, true)) { +SectionSP module_section_sp =

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk requested review of this revision. kwk added a comment. This revision is now accepted and ready to land. Tests did pass so this change is ready for review @labath @jankratochvil . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 222845. kwk marked 12 inline comments as done. kwk added a comment. - Change logic and comment for when .dynsym is parsed - Use different pattern for error checking - use less auto - Remove required system-linux test feature from LZMA tests Repository: rG

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk planned changes to this revision. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2711-2731 Section *symtab = section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get(); -if (!symtab) { - // The

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/lit/Modules/ELF/minidebuginfo-corrupt-xz.yaml:1 +# REQUIRES: system-linux, lzma + kwk wrote: > labath wrote: > > system-linux shouldn't be required here. One of the reasons I wanted to > > have these tests is that

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/lit/Modules/ELF/minidebuginfo-corrupt-xz.yaml:1 +# REQUIRES: system-linux, lzma + labath wrote: > system-linux shouldn't be required here. One of the reasons I wanted to have >

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @MaskRay I've addressed your comments. Comment at: lldb/source/Host/common/LZMA.cpp:129 + uint64_t uncompressedSize = 0; + auto err = getUncompressedSize(InputBuffer, uncompressedSize); + if (err) labath wrote: > MaskRay wrote: > > if

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219848. kwk marked 5 inline comments as done. kwk added a comment. - Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks great now. Thank you for your patience. Just make sure to deal with the breakages from the other patch first. If the fix is non trivial, or if it's going to take a while, then

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219680. kwk added a comment. Rebased on master to include changes from D67390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2711-2731 Section *symtab = section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get(); -if (!symtab) { - // The

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I have greatly improved the set and hit breakpoint test. Thank you again @jankratochvil for bringing my attention to `-Wl,--dynamic-list`. That helped to put one symbol in `.dynsym` explicitly. I will see if I can utilize that knowledge to separate out the patch

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219369. kwk added a comment. - Remove -x from %lldb because that expands to the command which already includes it - Improve and fix the minidebuginfo-set-and-hit-breakpoint.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

MaskRay added inline comments. Comment at: lldb/source/Host/common/LZMA.cpp:124 + llvm::SmallVectorImpl ) { + if (InputBuffer.size() == 0) +return llvm::createStringError(llvm::inconvertibleErrorCode(), empty Comment

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/lit/Breakpoint/minidebuginfo-set-and-hit-breakpoint.test:50 + +# RUN: LD_LIBRARY_PATH=$LD_LIBRARY_PATH:%T %lldb -x -b -o 'b multiplyByThree' -o 'b multiplyByFour' -o 'breakpoint list -v' -o 'run'

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added a comment. labath, please see my answer to your question and maybe help me out why you think I don't test what I want to test. Comment at: lldb/lit/Breakpoint/minidebuginfo-set-and-hit-breakpoint.test:50 + +# RUN:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/include/lldb/Host/LZMA.h:24-25 + +llvm::Error getUncompressedSize(llvm::ArrayRef InputBuffer, +uint64_t ); + kwk wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219064. kwk marked 16 inline comments as done. kwk added a comment. - Removed not needed test dependencies - Changed return type of lzma::getUncompressedSize - Moved minidebuginfo to subtree that deals with ELF - Apply review comments Repository: rG LLVM

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. I've tackled the easy comments now and will come back to the more detailed ones as well. I'm not ignoring them. Comment at: lldb/CMakeLists.txt:101 - set(LLDB_TEST_DEPS lldb) + set(LLDB_TEST_DEPS lldb llvm-nm llvm-strip) labath

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/lit/Breakpoint/minidebuginfo-corrupt-xz.yaml:13 + +# RUN: %lldb -x -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s + labath wrote: > You shouldn't need an explicit `-x`

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. Thank you for adding the tests, and for adding the `xz` detection to lit in particular. We're getting _reaally_ close now. I have a bunch more comments, including highlighting some you seems to have missed from earlier, but they are all just about polishing. The only

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. I think we're getting pretty close. I have a couple of extra comments inline, but they're all pretty minor, I hope. I'd just like to add some more tests, per our discussion on the IRC, and I have some doubts about what exactly is the test you've written actually

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218623. kwk added a comment. squashed and rebased on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218621. kwk added a comment. - remove not needed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218618. kwk marked an inline comment as done. kwk added a comment. Herald added a reviewer: alexshap. - add lit test for minidebuginfo - Fixup - test - Fiddle with the lit test - Fix binary in lit test - Working lit test - still need to only run it when

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1901 + ArchSpec spec = m_gnuDebugDataObjectFile->GetArchitecture(); + if (spec && m_gnuDebugDataObjectFile->SetModulesArchitecture(spec)) { +return m_gnuDebugDataObjectFile;

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I did go over a lot of your comments. Thank you for helping me in becoming in a better contributor. I'm still not done with the python/make -> lit test transition but the rest is mostly covered. Comment at: lldb/cmake/modules/LLDBConfig.cmake:337

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218374. kwk marked 24 inline comments as done. kwk added a comment. - Remove left-over variable in CMake - Move LLDB_ENABLE_LZMA into Config.h.cmake - Remove unused code - Change signature of lldb_private::lzma::uncompress - Fixup - Fixup - When using the

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:341 + if (LIBLZMA_FOUND) + add_definitions(-DLLDB_ENABLE_LZMA) +include_directories(${LIBLZMA_INCLUDE_DIRS}) labath wrote: > Please put this into `Config.h.cmake`. I know a

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:337 +find_package(LibLZMA) +cmake_dependent_option(LLDB_ENABLE_LZMA "Support LZMA compression" ON "LIBLZMA_FOUND" OFF) +set(LLDB_LIBLZMA_LIBRARIES) This looks like a really useful

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h:395 + + std::shared_ptr m_gnuDebugDataObjectFile; }; labath wrote: > move this next to other instance variables. Fixed in

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218300. kwk marked an inline comment as done. kwk added a comment. - Moved and renamed m_gnu_debug_data_object_file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 5 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1849-1851 + if (m_gnuDebugDataObjectFile != nullptr) { +return m_gnuDebugDataObjectFile; + } labath wrote: > Not a big deal,

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218299. kwk added a comment. - Move find LZMA section in CMake from LLVM to LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218297. kwk marked 3 inline comments as done. kwk added a comment. - Moved .symtab add/replace to OBjectFileELF::CreateSections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218289. kwk marked 3 inline comments as done. kwk added a comment. - Fix DataExtractor data. llvm does not "always use auto". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218288. kwk added a comment. - add @skipIfLzmaSupportMissing and cleanup - Don't put braces around one statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. In D66791#1651300 , @kwk wrote: > Currently the test > `lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py` > fails if `LLVM_ENABLE_LZMA` is not defined because the test stupidly assumes > that support

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217933. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZMA.h

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. Currently the test `lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py` fails if `LLVM_ENABLE_LZMA` is not defined because the test stupidly assumes that support for minidebuginfo is available. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217924. kwk marked an inline comment as done. kwk added a comment. - Fix header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp:79 + // If there's none in the orignal object file, we add it to it. + if (auto gdd_obj_file = + obj_file->GetGnuDebugDataObjectFile()) { labath wrote: >

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217895. kwk added a comment. - fixed lzma functions when LLVM_ENABLE_LZMA is not enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217894. kwk marked 4 inline comments as done. kwk added a comment. - Apply review comments - Move LZMA logic to lldb/Host/LZMA.h as suggested by labath - Simplify LZMA function signatures - Remove LZMA_OK from switch - Add llvm-nm to the list of lldb test

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

shafik added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:271 unsigned char out[sizeof(Val)]; - std::memcpy(in, , sizeof(Val)); + memcpy(in, , sizeof(Val)); for (unsigned i = 0; i < sizeof(Val); ++i) What are you building on that

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. Looks mostly fine, but you'll need to split this patch up. You'll want a separate review (and test) for the yaml2obj changes. Also, the lzma code should not live inside ObjectFileELF. I'd put it somewhere under `lldb/Host/LZMA.h`. For how to wrap lzma, I'd suggest

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217341. kwk added a comment. - Added documentation source for mini debuginfo commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217339. kwk added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/Makefile

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217334. kwk added a comment. - Improve documentation of GetGnuDebugDataObjectFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217331. kwk added a comment. - Change header comment of minidebuginfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py:1 +""" Testing debugging of a binary with "mixed" dwarf (with/without fission). """ +import lldb I just

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk created this revision. Herald added subscribers: llvm-commits, lldb-commits, MaskRay, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: espindola. Herald added projects: LLDB, LLVM. kwk added reviewers: labath, jankratochvil. kwk marked an inline comment as done. kwk updated