This revision was automatically updated to reflect the committed changes.
Closed by commit rG939ca455e72e: [lldb] Fix string summary of an empty
NSPathStore2 (authored by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68010/new/
teemperor updated this revision to Diff 251184.
teemperor added a comment.
- Rebased the patch.
This has been (really) delayed because of the whole unit test I wanted to
write, but I'll just land this as-is (as having this broken even longer just
because I haven't written that new unit test
shafik added inline comments.
Comment at: lldb/source/DataFormatters/StringPrinter.cpp:544
bool is_truncated = false;
const auto max_size =
process_sp->GetTarget().GetMaximumSizeOfStringSummary();
Why not just make this `uint32_t` making this `auto`
aprantl added inline comments.
Comment at: lldb/include/lldb/DataFormatters/StringPrinter.h:120
+
+bool GetHasSourceSize() const { return m_has_source_size; }
+
I don't know the LLDB rules that well: is the convention really `GetHas`
instead of `Has`?
teemperor updated this revision to Diff 221702.
teemperor edited the summary of this revision.
teemperor added a comment.
- Land the NFC test additions to other string classes as separate NFC commits.
- Rebase on the already landed refactoring.
CHANGES SINCE LAST ACTION
teemperor created this revision.
teemperor added reviewers: aprantl, JDevlieghere, shafik.
Herald added subscribers: lldb-commits, abidh, christof.
Herald added a project: LLDB.
Printing a summary for an empty NSPathStore2 string currently prints random
bytes behind the empty string pointer from
