[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG3aa7e76677f1: MinidumpYAML: Add support for the memory info list stream (authored by labath). Herald added a subscriber: hiraditya. Changed prior to commit:

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:116 + + MemoryInfoListStream() + : Stream(StreamKind::MemoryInfoList, MaskRay wrote: > Move default constructor above. Done, I've also

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

MaskRay accepted this revision. MaskRay added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector Infos) + : Stream(StreamKind::MemoryInfoList, grimar wrote: > Maybe be more explicit here,

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 ___ lldb-commits

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath updated this revision to Diff 224065. labath marked 2 inline comments as done. labath added a comment. Address review comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 Files:

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath added inline comments. Comment at: lib/ObjectYAML/MinidumpEmitter.cpp:166 +Header.SizeOfEntry = sizeof(minidump::MemoryInfo); +Header.NumberOfEntries = InfoList.Infos.size(); +File.allocateNewObject(Header); grimar wrote: > Probably just > >

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

grimar added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector Infos) + : Stream(StreamKind::MemoryInfoList, Maybe be more explicit here, i.e. ``` std::vector & ``` ?

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

jhenderson added subscribers: MaskRay, grimar. jhenderson added a comment. FYI, I'm going to be away for 2 and a half weeks from the end of work today, so won't have time to look at these if I don't get to them later today. I have no issues with other people reviewing them. You might want to

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

clayborg added a comment. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath added a comment. In D68645#1699705 , @JosephTremoulet wrote: > Nit: Title says "thread" rather than "memory info" Woops, sorry about that. Should be fixed now. Repository: rL LLVM CHANGES SINCE LAST ACTION