[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-14 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna added a comment. In D68738#1708159 , @stella.stamenova wrote: > This is still failing on the Windows bot. Please fix it ASAP or revert it. fix here https://reviews.llvm.org/D68951 Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-14 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna added a comment. In D68738#1708159 , @stella.stamenova wrote: > This is still failing on the Windows bot. Please fix it ASAP or revert it. Sorry,i didn’t see this. I’ll fix it today Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-14 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. This is still failing on the Windows bot. Please fix it ASAP or revert it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/ https://reviews.llvm.org/D68738

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-11 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. This is failing on the windows bot. There was already another failure, so you probably didn't get an email: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9727 http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9760 Repository:

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-10 Thread Lawrence D'Anna via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGab1cd65f1914: update TestRunCommandInterpreterAPI to use SBFile (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/ https://reviews.llvm.org/D68738

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

2019-10-09 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a subscriber: aprantl. Herald added a project: LLDB. If you look at what this test is doing, it's actually quite mysterious why it works at all. It sets the input file inside a