This revision was automatically updated to reflect the committed changes.
Closed by commit rGd3bd5b3d71ae: eliminate virtual methods from
PythonDataObjects (authored by lawrence_danna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68918/new/
lawrence_danna updated this revision to Diff 224924.
lawrence_danna added a comment.
rebased, and added in explicit default constructors for MSVC's sake.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68918/new/
https://reviews.llvm.org/D68918
lawrence_danna marked an inline comment as done.
lawrence_danna added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:188-192
// PythonObject is implicitly convertible to PyObject *, which will call the
// wrong overload. We
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Yes, this definitely looks better. Ideally, I'd like to get rid of the `Reset`
functions altogether, and just ensure we already create/return fully valid
objects (probably via factory
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, zturner.
Herald added a project: LLDB.
This patch eliminates a bunch of boilerplate from
PythonDataObjects, as well as the use of virtual methods.
In my opinion it also makes the Reset
