[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk abandoned this revision. kwk added a comment. Abandoning for D69041 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. I've posted a change for yaml2obj/obj2yaml here: D69041 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

labath added a comment. Thank you guys for jumping onto this. This will be very useful in lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. In D68943#1710525 , @MaskRay wrote: > In D68943#1709998 , @grimar wrote: > > > Ok, I was able to debug it finally. > > > > I think we should add a .symtab in a few more cases implicitly. > >

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

MaskRay added a comment. In D68943#1709998 , @grimar wrote: > Ok, I was able to debug it finally. > > I think we should add a .symtab in a few more cases implicitly. > For example, when we have a SHT_RELA/SHT_REL section that has an empty Link, > i.e.

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. Ok, I was able to debug it finally. I think we should add a .symtab in a few more cases implicitly. For example, when we have a SHT_RELA/SHT_REL section that has an empty Link, i.e. it refers to .symtab by default and we should provide it. There are other cases, like when

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. In D68943#1709330 , @kwk wrote: > I noticed that the order of sections does matter to some tests. Before the > `.symtab` section was always the first one and now it is the last of the > implicit sections being created. Some

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. I noticed that the order of sections does matter to some tests. Before the `.symtab` section was always the first one and now it is the last of the implicit sections being created. Some `Link: X` checks break because `X` points to a different section. In order to

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. @grimar I've tackled the most obvious of your comments. I will now see what fails in `llvm/test/tools/yaml2obj`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224968. kwk marked 6 inline comments as done. kwk added a comment. - Remove unnecessary section - Have consitent ordering of run, check and YAML lines - use ## for comments in YAML - Remove not needed Entry and Sections - Only have Name for a symbol - Moved test

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. I have not looked what is needed to fix yaml2obj testcases yet, but below there are few first comments. Also, 2 LLVM side tests added should live in "llvm/test/tools/yaml2obj" I think (not in llvm/test/ObjectYAML/ELF/), because this is actually the place where we test

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. In D68943#1708068 , @MaskRay wrote: > This is not correct. A lot of yaml2obj tests fail with: > > > yaml2obj: error: unknown section referenced: '.symtab' by YAML section > > '.rela.text' @MaskRay I'm so sorry. You're absolutely

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

MaskRay added a comment. This is not correct. A lot of yaml2obj tests fail with: > yaml2obj: error: unknown section referenced: '.symtab' by YAML section > '.rela.text' The problem is that .symtab can be the sh_link field of relocation sections, .llvm_addrsig, and some sections that may be

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224852. kwk added a comment. - moved test files over to llvm subtree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files:

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk marked an inline comment as done. kwk added a comment. Moved `yaml2obj` tests under llvm subtree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk planned changes to this revision. kwk added a comment. Move tests over to `llvm/llvm/test/ObjectYAML/ELF/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

labath added reviewers: grimar, MaskRay, jhenderson. labath added a comment. +llvm yaml2obj folks. Thank you for creating this diff. Please see comments inline. Comment at: lldb/test/Shell/ObjectFile/ELF/no-symtab-generated.yaml:1 +# In this test we don't explicitly define a

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk marked an inline comment as done. kwk added inline comments. Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:379-380 // being a single SHT_SYMTAB section are upheld. - std::vector Symbols; + Optional> Symbols; std::vector DynamicSymbols; };

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224839. kwk added a comment. - restore formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files: lldb/test/Shell/ObjectFile/ELF/minidebuginfo-corrupt-xz.yaml

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk created this revision. kwk added a reviewer: labath. Herald added subscribers: llvm-commits, lldb-commits, MaskRay, hiraditya, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added projects: LLDB, LLVM. kwk updated this revision to Diff

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224838. kwk added a comment. - Silence FileCheck in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files: