[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a comment. Cool. I'm glad we could figure this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

clayborg added a comment. sounds like we have a plan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace added a comment. man, thanks for your feedback! Indeed, i was trying to solve some problems that don't exist yet. Later when I add apk debugging support, I'll figure out what's the best way to retrieve apk specific information, but for now display_name is more than enough Repository:

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a comment. Thank you for doing the investigation, and the detailed summary. I'm going to respond inline. In D68968#1713788 , @wallace wrote: > Thanks for your feedback and to @clayborg for an offline discussion we had. > > I'm going to add

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace added a comment. Thanks for your feedback and to @clayborg for an offline discussion we had. I'm going to add three new attributes to the ProcessInfo class, with corresponding parameters in the gdb-remote packet - display_name: This is a custom display name that the server can set for

Re: [Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

simpleperf reads argv[0] from /proc//cmdline for display purposes. If not for display, a package name is expected from user inputs. On Thu, Oct 17, 2019 at 1:33 PM enh wrote: > nothing i know of. +yabinc might have dealt with this with simpleperf... > > On Thu, Oct 17, 2019 at 12:54 PM Dan

Re: [Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

nothing i know of. +yabinc might have dealt with this with simpleperf... On Thu, Oct 17, 2019 at 12:54 PM Dan Albert via Phabricator wrote: > > danalbert added a subscriber: enh. > danalbert added a comment. > > In D68968#1710520 , @labath wrote: > > >

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

danalbert added a subscriber: enh. danalbert added a comment. In D68968#1710520 , @labath wrote: > Independently, I am wondering if there's a better way to link the process id > to a bundle. Using argv[0] might be ok if we're using it just for display >

Re: [Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

> On Oct 17, 2019, at 1:35 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In D68968#1712018 , @jingham wrote: > >> I don't think it would be good to make it hard to see the actual path (if >> you have it) as well as the

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a comment. In D68968#1712018 , @jingham wrote: > I don't think it would be good to make it hard to see the actual path (if you > have it) as well as the bundle ID. If you are working on system components, > you want to know that you are

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

jingham added a comment. As Greg said, iOS (and macOS as well, though less directly) have the notion of bundleID. At present, lldb doesn't directly use/figure out the bundle ID, though it could either from the binary itself or from debugserver, which does have to know that. As far as I know

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:220-222 + if (process_info.GetNameAsStringRef().empty() && + !process_info.GetArg0().empty()) { +process_info.SetBundleID(process_info.GetArg0());

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a reviewer: jingham. labath added subscribers: danalbert, jingham. labath added a comment. Introducing a "bundle" identifier as a first class concept sounds reasonable to me, particularly if that concept can be applied to more than one platform. But since we're talking about iOS,

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

clayborg added a comment. LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225113. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: lldb/include/lldb/Utility/ProcessInfo.h

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225112. wallace edited the summary of this revision. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225107. wallace added a comment. Herald added a subscriber: krytarowski. now using bundle_id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: