This revision was automatically updated to reflect the committed changes.
Closed by commit rG52f3a2faf92c: [lldb][NFC] Move LLVM RTTI implementation from
enum to static ID variable (authored by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
davide added a comment.
LGTM.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70070/new/
https://reviews.llvm.org/D70070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Swift aside, I think it's also good that the generic Expression class does not
need to know about the various kinds of expressions that the Clang Expression
parser plugin wants to invent.
teemperor created this revision.
teemperor added reviewers: labath, davide.
teemperor added a project: Upstreaming LLDB's downstream patches.
Herald added subscribers: lldb-commits, JDevlieghere.
Herald added a project: LLDB.
swift-lldb currently has to patch the ExpressionKind enum to add
