This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fdbc0728d4b: [DWARF] Handle call sites with indirect call
targets (authored by vsk).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D70100?vs=228921=230704#toc
vsk marked an inline comment as done.
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:453
/// PC addresses (in increasing order).
- llvm::MutableArrayRef GetCallEdges();
+ llvm::ArrayRef> GetCallEdges();
aprantl wrote:
> Since
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/include/lldb/Symbol/Function.h:453
/// PC addresses (in increasing order).
- llvm::MutableArrayRef GetCallEdges();
+ llvm::ArrayRef>
vsk added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70100/new/
https://reviews.llvm.org/D70100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vsk updated this revision to Diff 228921.
vsk added a comment.
- Remove a few more redundant Optional initializations.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70100/new/
https://reviews.llvm.org/D70100
Files:
lldb/include/lldb/Symbol/Function.h
vsk updated this revision to Diff 228920.
vsk marked 3 inline comments as done.
vsk added a comment.
- Add doxygen comments describing {Direct,Indirect}CallEdge & address the rest
of Adrian's comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70100/new/
aprantl added a comment.
Mechanically, this seems reasonable.
Comment at: lldb/include/lldb/Symbol/Function.h:334
- DISALLOW_COPY_AND_ASSIGN(CallEdge);
+/// An indirect call site.
+class IndirectCallEdge : public CallEdge {
You might want to briefly explain
vsk created this revision.
vsk added reviewers: aprantl, friss, jingham.
Split CallEdge into DirectCallEdge and IndirectCallEdge. Teach
DWARFExpression how to evaluate entry values in cases where the current
activation was created by an indirect call.
Writing tests for this is challenging, at
