[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa16bf15fe38: [lldb-vscode] Fix a race in test_extra_launch_commands (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70127/new/

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

labath added a comment. In D70127#1743077 , @clayborg wrote: > --stop-at-entry only really works for Darwin That's not true. :) The reason this works on linux (and elsewhere) is that we don't use posix_spawn, but instead we launch the process

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

clayborg added a comment. --stop-at-entry only really works for Darwin since its posix_spawn has a flag that will stop it at the entry point before anything executes. On linux, does this flag do anything? Comment at:

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

jingham added a comment. It looks like all the continue routines in lldbvscode_testcase.py use self.vscode.wait_for_stopped() after setting the target going. Would that fix the problem here? Without knowing anything about the protocol VSCode is using, I can't say that's right. But if launch

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I agree - as there is currently: self.verify_commands('launchCommands', output, launchCommands) # Verify the "stopCommands" here self.continue_to_next_stop() BTW I did not

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

labath created this revision. labath added reviewers: clayborg, kusmour, jankratochvil. Herald added a project: LLDB. The test used a non-stopping "run" command to launch the process. This is different from the regular launch with no extra launch commands, which uses eLaunchFlagStopAtEntry to