This revision was automatically updated to reflect the committed changes.
Closed by commit rG8b8185bb1b45: Avoid triple corruption while merging core
info (authored by omjavaid).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70155/new/
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Thanks for the ping, yes this looks good to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70155/new/
https://reviews.llvm.org/D70155
omjavaid added a comment.
Ping @jasonmolenda
Any comments or LGTM?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70155/new/
https://reviews.llvm.org/D70155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath added a comment.
Thanks. This behavior makes sense to me. @jasonmolenda, @clayborg, do you see
any problems with this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70155/new/
https://reviews.llvm.org/D70155
___
lldb-commits
omjavaid updated this revision to Diff 229971.
omjavaid added a comment.
Added a unittest as suggested by @labath.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70155/new/
https://reviews.llvm.org/D70155
Files:
lldb/source/Utility/ArchSpec.cpp
labath added a comment.
Can you add a test case for this? I assuming it could be similar to one of the
existing ArchSpec::MergeFrom tests in
https://github.com/llvm/llvm-project/blob/7dd7a3607596a51044b8706ebf6df2e613ce1e9b/lldb/unittests/Utility/ArchSpecTest.cpp#L137
CHANGES SINCE LAST
omjavaid created this revision.
omjavaid added reviewers: labath, jasonmolenda, clayborg.
Herald added a subscriber: kristof.beyls.
This patch fixes a bug where when target triple created from elf information is
arm-*-linux-eabihf and platform triple is armv8l-*-linux-gnueabihf. Merging
both
