[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

teemperor added a comment. In D70324#1757070 , @rupprecht wrote: > In D70324#1755712 , @davide wrote: > > > In D70324#1755704 , @labath wrote: > > > > > [This is probably

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

rupprecht added a comment. In D70324#1755712 , @davide wrote: > In D70324#1755704 , @labath wrote: > > > [This is probably not the right patch, as the last run on that bot still > > doesn't have this commit.] >

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

davide added a comment. In D70324#1755704 , @labath wrote: > [This is probably not the right patch, as the last run on that bot still > doesn't have this commit.] > > My understanding is that all pexpect tests are failing on that bot and are > skipped

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

labath added a subscriber: teemperor. labath added a comment. [This is probably not the right patch, as the last run on that bot still doesn't have this commit.] My understanding is that all pexpect tests are failing on that bot and are skipped with `@skipIfAsan`. Probably this one needs to be

Re: [Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

I'm not at a computer right now, so feel free to revert this commit now and I'll take a look at then failures later. Thanks! On Thu, Nov 21, 2019, 11:09 AM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > Looks like we happened to be

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

JDevlieghere added a comment. Looks like we happened to be looking at this at the same time :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70324/new/ https://reviews.llvm.org/D70324 ___ lldb-commits

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

JDevlieghere added a comment. Hey Jordan, the test is failing on the sanitized bot on GreenDragon. The error is `Could not terminate the child`. Could you have a look? http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/541/console Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

davide added a comment. Hey Jordan, it looks like some of the changes to TestEditLine [or adjacent to it] broke the sanitized build on macOS. Can I ask you to take a look? Thanks http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/539/console Repository: rG LLVM Github

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG327a18ca0a00: [lldb][test] Prevent \n in calls to lldbs expect() test helper. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D70324?vs=229593=230157#toc Repository: rG

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for getting to the bottom of this. Adding the \n check is fine. The "expect" function was meant to be an pexpect equivalent of the "expect" function in regular tests (which also just

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

merge_guards_bot added a comment. Build result: pass - 60084 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. expect() forwards its command to sendline(). This can be problematic if the command already contains a newline: sendline() unconditionally adds a newline