[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth closed this revision. amccarth added a comment. This landed in 3b69f0c5550a229dd6d39e361182cdd7cecc36a4 , but there was a typo in the patch description so the tools didn't automatically close this. CHANGES SINCE

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059 if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) -

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth updated this revision to Diff 230303. amccarth marked an inline comment as done. amccarth added a comment. Reverted unintended change caught by reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70458/new/ https://reviews.llvm.org/D70458 Files:

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth marked 2 inline comments as done. amccarth added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059 if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) - module_spec.GetFileSpec().GetFilename() =

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059 if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) - module_spec.GetFileSpec().GetFilename() = symbol_fspec.GetFilename(); +

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth created this revision. amccarth added a reviewer: labath. Made small improvements while debugging through CommandObjectTarget::AddModuleSymbols. 1. Refactored error case for an early out, reducing the indentation of the rest of this long function. 2. Clarified some comments by