[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe81268d03e73: [lldb/Reproducers] Support multiple GDB remotes (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71105/new/

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere updated this revision to Diff 233131. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71105/new/ https://reviews.llvm.org/D71105 Files: lldb/include/lldb/Utility/GDBRemote.h lldb/include/lldb/Utility/Reproducer.h

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere added a comment. In D71105#1774936 , @labath wrote: > This looks better. Ideally I wouldn't even have Utility/GDBRemote.h, but as > Process/gdb-remote is not a very good place for it either (it messes with > lldb-server dependencies), we

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere updated this revision to Diff 232867. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71105/new/ https://reviews.llvm.org/D71105 Files: lldb/include/lldb/Utility/GDBRemote.h lldb/include/lldb/Utility/Reproducer.h

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:439 - std::vector packets; - yaml::Input yin((*error_or_file)->getBuffer()); - yin >> packets; + static std::unique_ptr> + multi_loader =

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

labath added a comment. This looks better. Ideally I wouldn't even have Utility/GDBRemote.h, but as Process/gdb-remote is not a very good place for it either (it messes with lldb-server dependencies), we can live with it for now. Comment at:

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere updated this revision to Diff 232653. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Address CR feedback. - Introduce `AbstractRecorder` to reuse code between the `PacketRecorder` and the `DataRecorder`. - Move GDB related reproducer code into

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

labath added a comment. Looks pretty straight-forward, but I am still not happy about how more and more of ProcessGDBRemote is infiltrating its way into the Utility module. I think that the reproducer code specific to gdb-remote should live next to the code it's capturing, and

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere added a comment. This patch is still missing a test and could use another pass over the `PacketRecorder` and `ProcessGDBRemoteProvider` to eliminate code duplication with `DataRecorder` and the `CommandProvider` on which they're based respectively. I wasn't able to get around to

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: abidh. Herald added a project: LLDB. When running the test suite with always capture on, a handful of tests are failing because they have multiple targets and therefore multiple GDB remote